Add pipefail to space_robots build so that it fails on error #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhansenbot
force-pushed
the
add_pipefail
branch
from
6f2b402
to
501481f
Compare
|
This fails the space_robots build as expected! |
|
Also updated |
|
Rebasing to |
mkhansenbot
force-pushed
the
add_pipefail
branch
from
b80e74f
to
fca11ab
Compare
|
@EzraBrooks - can you review and approve? |
EzraBrooks
approved these changes
Aug 17, 2023
eholum
pushed a commit
to eholum/docker
that referenced
this pull request
Jun 9, 2024
Following a minimal set of rules to track changes, associate them to milestones and releases, and determine the process of accepting them, will help us comply with processes existing at NASA (e.g., NPR7150.2D) and other organizations for Space ROS to be accepted in space software applications. This commit documents in the CONTRIBUTING file the process agreed upon by the Space ROS Technical Committee.
eholum
pushed a commit
to eholum/docker
that referenced
this pull request
Jun 9, 2024
To increase visibility of the contributing guidelines and facilitate early adoption by potential contributors, this commit adds a link to the CONTRIBUTING.md file from the top-level README.
eholum
pushed a commit
to eholum/docker
that referenced
this pull request
Jun 9, 2024
…ules Document contribution rules (space-ros#76).
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
Following a minimal set of rules to track changes, associate them to milestones and releases, and determine the process of accepting them, will help us comply with processes existing at NASA (e.g., NPR7150.2D) and other organizations for Space ROS to be accepted in space software applications. This commit documents in the CONTRIBUTING file the process agreed upon by the Space ROS Technical Committee.
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
To increase visibility of the contributing guidelines and facilitate early adoption by potential contributors, this commit adds a link to the CONTRIBUTING.md file from the top-level README.
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
…ntrib-rules Document contribution rules (space-ros/docker#76).
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
Add pipefail to space_robots build so that it fails on error
eholum
pushed a commit
to eholum/space-ros
that referenced
this pull request
Jun 26, 2024
Add pipefail to space_robots build so that it fails on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
set -eo pipefailto the space_robots workflow to fix #75